[
https://issues.apache.org/jira/browse/SPARK-31844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149266#comment-17149266
]
jiaan.geng commented on SPARK-31844:
------------------------------------
According discussion between [~Ngone51] and me. It's not worth to do this.
Please references my fork branch
https://github.com/beliefer/spark/commit/09ed72589a2bbd201f9c6bb61999b8b066026090
> DAGSchedulerSuite: For the pattern of failed + assert, extract the general
> method
> ---------------------------------------------------------------------------------
>
> Key: SPARK-31844
> URL: https://issues.apache.org/jira/browse/SPARK-31844
> Project: Spark
> Issue Type: Sub-task
> Components: Spark Core
> Affects Versions: 3.1.0
> Reporter: jiaan.geng
> Priority: Major
>
> DAGSchedulerSuite exists many test case(e.g. trivial job failure | run
> shuffle with map stage failure) contains the pattern of failed + assert, such
> as:
> {code:java}
> test("trivial job failure") {
> submit(new MyRDD(sc, 1, Nil), Array(0))
> failed(taskSets(0), "some failure")
> assert(failure.getMessage === "Job aborted due to stage failure: some
> failure")
> assert(sparkListener.failedStages === Seq(0))
> assertDataStructuresEmpty()
> }
> {code}
> We should extract the general method like failedAndCheck(taskSet: TaskSet,
> message: String, predicate)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
