[
https://issues.apache.org/jira/browse/SPARK-5524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301036#comment-14301036
]
Sean Owen commented on SPARK-5524:
----------------------------------
If you mean, why call log4j directly at all instead of slf4j, it is because you
can't set log levels with slf4j. Centralizing logic is good but doesn't change
that. The log level values are themselves are log4j classes so you'd have to
make yet another light API for this with Strings on top of log4j. There may not
be much net win here but propose a PR with all that in mind.
> Remove messy dependencies to log4j
> ----------------------------------
>
> Key: SPARK-5524
> URL: https://issues.apache.org/jira/browse/SPARK-5524
> Project: Spark
> Issue Type: Bug
> Reporter: Jacek Lewandowski
>
> There are some tickets regarding loosening the dependency on Log4j, however
> some classes still use the following scheme:
> {code}
> if (Logger.getLogger(classOf[SomeClass]).getLevel == null) {
> Logger.getLogger(classOf[SomeClass]).setLevel(someLevel)
> }
> {code}
> This doesn't look good and make it difficult to track why some logs are
> missing when you use Log4j and why they are flooding when you use something
> else, like logback.
> There is a Logging class which checks whether we use Log4j or not. Why not
> delegate all of such invocations, where the Logging class could handle it
> properly, maybe considering more logging implementations?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
