[ 
https://issues.apache.org/jira/browse/SPARK-32473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dongjoon Hyun updated SPARK-32473:
----------------------------------
    Description: 
This issue aims to fix `SorterSuite` and `RadixSortSuite` in Scala 2.13 by 
using `sameElements` instead of `IndexSeqView.==`.

Scala 2.13 reimplements `IndexSeqView` and the behavior is different.
- https://docs.scala-lang.org/overviews/core/collections-migration-213.html

{code}
Welcome to Scala 2.12.10 (OpenJDK 64-Bit Server VM, Java 1.8.0_262).
Type in expressions for evaluation. Or try :help.

scala> Seq(1,2,3).toArray.view == Seq(1,2,3).toArray.view
res0: Boolean = true
{code}

{code}
Welcome to Scala 2.13.3 (OpenJDK 64-Bit Server VM, Java 1.8.0_262).
Type in expressions for evaluation. Or try :help.

scala> Seq(1,2,3).toArray.view == Seq(1,2,3).toArray.view
val res0: Boolean = false
{code}

{code}
$ dev/change-scala-version.sh 2.13
$ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none 
-DwildcardSuites=org.apache.spark.util.collection.unsafe.sort.RadixSortSuite
...
Tests: succeeded 9, failed 36, canceled 0, ignored 0, pending 0
*** 36 TESTS FAILED ***

$ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none 
-DwildcardSuites=org.apache.spark.util.collection.SorterSuite
...
Tests: succeeded 3, failed 1, canceled 0, ignored 2, pending 0
*** 1 TEST FAILED ***
{code}

> Use sameElements instead IndexSeqView.==
> ----------------------------------------
>
>                 Key: SPARK-32473
>                 URL: https://issues.apache.org/jira/browse/SPARK-32473
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Spark Core, Tests
>    Affects Versions: 3.1.0
>            Reporter: Dongjoon Hyun
>            Priority: Major
>
> This issue aims to fix `SorterSuite` and `RadixSortSuite` in Scala 2.13 by 
> using `sameElements` instead of `IndexSeqView.==`.
> Scala 2.13 reimplements `IndexSeqView` and the behavior is different.
> - https://docs.scala-lang.org/overviews/core/collections-migration-213.html
> {code}
> Welcome to Scala 2.12.10 (OpenJDK 64-Bit Server VM, Java 1.8.0_262).
> Type in expressions for evaluation. Or try :help.
> scala> Seq(1,2,3).toArray.view == Seq(1,2,3).toArray.view
> res0: Boolean = true
> {code}
> {code}
> Welcome to Scala 2.13.3 (OpenJDK 64-Bit Server VM, Java 1.8.0_262).
> Type in expressions for evaluation. Or try :help.
> scala> Seq(1,2,3).toArray.view == Seq(1,2,3).toArray.view
> val res0: Boolean = false
> {code}
> {code}
> $ dev/change-scala-version.sh 2.13
> $ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none 
> -DwildcardSuites=org.apache.spark.util.collection.unsafe.sort.RadixSortSuite
> ...
> Tests: succeeded 9, failed 36, canceled 0, ignored 0, pending 0
> *** 36 TESTS FAILED ***
> $ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none 
> -DwildcardSuites=org.apache.spark.util.collection.SorterSuite
> ...
> Tests: succeeded 3, failed 1, canceled 0, ignored 2, pending 0
> *** 1 TEST FAILED ***
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to