[
https://issues.apache.org/jira/browse/SPARK-32933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200580#comment-17200580
]
Xiangrui Meng commented on SPARK-32933:
---------------------------------------
Why do we keep using the @keyword_only annotation after we switched to use `*`
syntax? I understand that we do not want to remove the keyword_only definition
at https://github.com/apache/spark/blob/master/python/pyspark/__init__.py#L101
because it was used widely outside Spark. But within Spark code base, I don't
think we still need to use it to annotate methods. We should also deprecate
keyword_only in Spark 3.1 so developers know to switch.
> Use keyword-only syntax for keyword_only methods
> ------------------------------------------------
>
> Key: SPARK-32933
> URL: https://issues.apache.org/jira/browse/SPARK-32933
> Project: Spark
> Issue Type: Improvement
> Components: PySpark
> Affects Versions: 3.1.0
> Reporter: Maciej Szymkiewicz
> Assignee: Maciej Szymkiewicz
> Priority: Minor
> Fix For: 3.1.0
>
>
> Since 3.0, provides syntax for indicating keyword-only arguments ([PEP
> 3102|https://www.python.org/dev/peps/pep-3102/]).
> It is not a full replacement for our current usage of {{keyword_only}}, but
> it would allow us to make our expectations explicit:
> {code:python}
> @keyword_only
> def __init__(self, degree=2, inputCol=None, outputCol=None):
> {code}
> {code:python}
> @keyword_only
> def __init__(self, *, degree=2, inputCol=None, outputCol=None):
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
