[
https://issues.apache.org/jira/browse/SPARK-33619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leanken.Lin updated SPARK-33619:
--------------------------------
Description:
```
In -SPARK-33460---
there is a bug as follow.
GetMapValueUtil generated code error when ANSI mode is on
s"""throw new NoSuchElementException("Key " + $eval2 + " does not exist.");"""
should be
s"""throw new java.util.NoSuchElementException("Key " + $eval2 + " does not
exist.");"""
But Why are
checkExceptionInExpression[Exception](expr, errMsg)
and sql/testOnly org.apache.spark.sql.SQLQueryTestSuite – -z ansi/map.sql
can't detect this Bug
it's because
1. checkExceptionInExpression is some what error, too. it should wrap with
withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key like CheckEvalulation, AND WE
SHOULD FIX this later.
2. SQLQueryTestSuite ansi/map.sql failed to detect because of the
ConstantFolding rules, it is calling eval instead of code gen in this case
```
was:
```
In -SPARK-33460---
there is a bug as follow.
GetMapValueUtil generated code error when ANSI mode is on
s"""throw new NoSuchElementException("Key " + $eval2 + " does not exist.");"""
should be
s"""throw new java.util.NoSuchElementException("Key " + $eval2 + " does not
exist.");"""
But Why are
checkExceptionInExpression[Exception](expr, errMsg)
and sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z ansi/map.sql
can't detect this Bug
it's because
1. checkExceptionInExpression is some what error, too. it should wrap with
withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key like CheckEvalulation
2. SQLQueryTestSuite ansi/map.sql failed to detect because of the
ConstantFolding rules, it is calling eval instead of code gen in this case
```
> GetMapValueUtil code generation error
> -------------------------------------
>
> Key: SPARK-33619
> URL: https://issues.apache.org/jira/browse/SPARK-33619
> Project: Spark
> Issue Type: Bug
> Components: SQL
> Affects Versions: 3.1.0
> Reporter: Leanken.Lin
> Priority: Major
>
> ```
> In -SPARK-33460---
> there is a bug as follow.
> GetMapValueUtil generated code error when ANSI mode is on
>
> s"""throw new NoSuchElementException("Key " + $eval2 + " does not exist.");"""
> should be
> s"""throw new java.util.NoSuchElementException("Key " + $eval2 + " does not
> exist.");"""
>
> But Why are
> checkExceptionInExpression[Exception](expr, errMsg)
> and sql/testOnly org.apache.spark.sql.SQLQueryTestSuite – -z ansi/map.sql
> can't detect this Bug
>
> it's because
> 1. checkExceptionInExpression is some what error, too. it should wrap with
> withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key like CheckEvalulation, AND WE
> SHOULD FIX this later.
> 2. SQLQueryTestSuite ansi/map.sql failed to detect because of the
> ConstantFolding rules, it is calling eval instead of code gen in this case
>
> ```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
