[ 
https://issues.apache.org/jira/browse/SPARK-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327238#comment-14327238
 ] 

Sean Owen commented on SPARK-5889:
----------------------------------

Yeah I wanted to do this in the original PR, although I think there's a small 
potential problem: what if {{kill}} fails? then you lose the PID file. In that 
case, a lot of bets are off anyway and it's not clear that subsequent retries 
would succeed.

Still, since the script handles old PID files already (er, it's trying to), I 
wonder if this can be slightly more conservative and only remove if kill 
succeeds?

> remove pid file in spark-daemon.sh after killing the process.
> -------------------------------------------------------------
>
>                 Key: SPARK-5889
>                 URL: https://issues.apache.org/jira/browse/SPARK-5889
>             Project: Spark
>          Issue Type: Bug
>    Affects Versions: 1.2.1
>            Reporter: Zhan Zhang
>
> Currently, if the thriftserver/history server are stopped. The pid file is 
> not deleted. The fix is trial, but it is important for some service checking 
> relying on the file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to