[ 
https://issues.apache.org/jira/browse/SPARK-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Or updated SPARK-5931:
-----------------------------
    Description: 
This is SPARK-5932's sister issue.

The naming of existing time configs is inconsistent. We currently have the 
following throughout the code base:

spark.network.timeout (seconds)
spark.executor.heartbeatInterval (milliseconds)
spark.storage.blockManagerSlaveTimeoutMs (milliseconds)
spark.yarn.scheduler.heartbeat.interval-ms (milliseconds)

Instead, my proposal is to simplify the config name itself and make everything 
accept time using the following format: 5s, 2ms, 100us. For instance:

spark.network.timeout = 5s
spark.executor.heartbeatInterval = 500ms
spark.storage.blockManagerSlaveTimeout = 100ms
spark.yarn.scheduler.heartbeatInterval = 400ms

We should do this soon before we keep introducing more time configs.

  was:
The naming of existing time configs is inconsistent. We currently have the 
following throughout the code base:

spark.network.timeout (seconds)
spark.executor.heartbeatInterval (milliseconds)
spark.storage.blockManagerSlaveTimeoutMs (milliseconds)
spark.yarn.scheduler.heartbeat.interval-ms (milliseconds)

Instead, my proposal is to simplify the config name itself and make everything 
accept time using the following format: 5s, 2ms, 100us. For instance:

spark.network.timeout = 5s
spark.executor.heartbeatInterval = 500ms
spark.storage.blockManagerSlaveTimeout = 100ms
spark.yarn.scheduler.heartbeatInterval = 400ms

We should do this soon before we keep introducing more time configs.


> Use consistent naming for time properties
> -----------------------------------------
>
>                 Key: SPARK-5931
>                 URL: https://issues.apache.org/jira/browse/SPARK-5931
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 1.0.0
>            Reporter: Andrew Or
>            Assignee: Andrew Or
>
> This is SPARK-5932's sister issue.
> The naming of existing time configs is inconsistent. We currently have the 
> following throughout the code base:
> spark.network.timeout (seconds)
> spark.executor.heartbeatInterval (milliseconds)
> spark.storage.blockManagerSlaveTimeoutMs (milliseconds)
> spark.yarn.scheduler.heartbeat.interval-ms (milliseconds)
> Instead, my proposal is to simplify the config name itself and make 
> everything accept time using the following format: 5s, 2ms, 100us. For 
> instance:
> spark.network.timeout = 5s
> spark.executor.heartbeatInterval = 500ms
> spark.storage.blockManagerSlaveTimeout = 100ms
> spark.yarn.scheduler.heartbeatInterval = 400ms
> We should do this soon before we keep introducing more time configs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to