Sean R. Owen created SPARK-36362: ------------------------------------ Summary: Omnibus Java code static analyzer warning fixes Key: SPARK-36362 URL: https://issues.apache.org/jira/browse/SPARK-36362 Project: Spark Issue Type: Improvement Components: Spark Core, SQL, Tests Affects Versions: 3.2.0 Reporter: Sean R. Owen Assignee: Sean R. Owen
Inspired by a recent Java code touch-up, I wanted to fix in one pass several lingering non-trivial issues with the Java code that a static analyzer turns up. Only a few of these have material effects, but some do, and figured we could avoid taking N PRs over time to address these. * Some int*int multiplications that widen to long maybe could overflow * Unnecessarily non-static inner classes * Some tests "catch (AssertionError)" and do nothing * Manual array iteration vs very slightly faster/simpler foreach * Incorrect generic types that just happen to not cause a runtime error * Missed opportunities for try-close * Mutable enums which shouldn't be * .. and a few other minor things -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org