[
https://issues.apache.org/jira/browse/SPARK-37678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461679#comment-17461679
]
Maciej Szymkiewicz commented on SPARK-37678:
--------------------------------------------
??It's an actual implementation of an abstract method
{{GroupBy._cleanup_and_return}} for {{{}SeriesGroupBy{}}}.??????
Yeah, my brain must be scrambled at this point.
So that's basically {{ps.DataFrame -> ps.Series}}, right?
> Incorrect annotations in SeriesGroupBy._cleanup_and_return
> -----------------------------------------------------------
>
> Key: SPARK-37678
> URL: https://issues.apache.org/jira/browse/SPARK-37678
> Project: Spark
> Issue Type: Bug
> Components: PySpark
> Affects Versions: 3.3.0
> Reporter: Maciej Szymkiewicz
> Priority: Major
>
> [{{SeriesGroupBy._cleanup_and_return}}|https://github.com/apache/spark/blob/02ee1ae10b938eaa1621c3e878d07c39b9887c2e/python/pyspark/pandas/groupby.py#L2997-L2998]
> annotations
> {code:python}
> def _cleanup_and_return(self, pdf: pd.DataFrame) -> Series:
> return first_series(pdf).rename().rename(self._psser.name)
> {code}
> are inconsistent:
> - If {{pdf}} is {{pd.DataFrame}} then output should be {{pd.Series}}.
> - If output is {{ps.Series}} then {{pdf}} should be {{ps.DataFrame}}.
> Doesn't seem like the method is used (it is possible that my search skills
> and PyCharm inspection failed), so I am not sure which of these options was
> intended.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
