[
https://issues.apache.org/jira/browse/SPARK-37996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486139#comment-17486139
]
Khalid Mammadov commented on SPARK-37996:
-----------------------------------------
Raised PR: https://github.com/apache/spark-website/pull/378
With following changes:
* It describes in the Pull request section of the Contributing page the actual
procedure and takes a contributor through a step by step process.
* It removes optional "Running tests in your forked repository" section on
Developer Tools page which is obsolete now and doesn't reflect reality anymore
i.e. it says we can test by clicking “Run workflow” button which is not
available anymore as workflow does not use "workflow_dispatch" event trigger
anymore and was removed in
* [[SPARK-35048][INFRA] Distribute GitHub Actions workflows to fork
repositories to share the resources
spark#32092|https://github.com/apache/spark/pull/32092]
* Instead it documents the new procedure that above PR introduced i.e.
contributors needs to use their own GitHub free workflow credits to test new
changes they are purposing and a Spark Actions workflow will expect that to be
completed before marking PR to be ready for a review.
* Some general wording was copied from "Running tests in your forked
repository" section on Developer Tools page but main content was rewritten to
meet objective
* Also fixed URL to developer-tools.html to be resolved by parser (that
converted it into relative URI) instead of using hard coded absolute URL.
> Contribution guide is stale
> ---------------------------
>
> Key: SPARK-37996
> URL: https://issues.apache.org/jira/browse/SPARK-37996
> Project: Spark
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 3.2.0
> Reporter: Khalid Mammadov
> Priority: Minor
>
> Contribution guide mentions below link to use to test on local repo before
> raising PR but the process has changed and documentation does not reflect it.
> https://spark.apache.org/developer-tools.html#github-workflow-tests
> Only digging into git log of "
> [.github/workflows/build_and_test.yml|https://github.com/apache/spark/commit/2974b70d1efd4b1c5cfe7e2467766f0a9a1fec82#diff-48c0ee97c53013d18d6bbae44648f7fab9af2e0bf5b0dc1ca761e18ec5c478f2]";
> I managed to find what the new process is. It was changed in
> [https://github.com/apache/spark/pull/32092] but documentation was not
> updated.
> I am happy to contribute to fix it but apparently
> [https://spark.apache.org/developer-tools.html] is hosted in Apache website
> rather that in the Spark source code
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
