[ 
https://issues.apache.org/jira/browse/SPARK-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355622#comment-14355622
 ] 

Nicholas Chammas commented on SPARK-5312:
-----------------------------------------

Thanks for looking into this [~boyork]. I'm looking forward to see what comes 
of it.

The goal, as you hinted at, is basically to give reviewers a complement to the 
MIMA check that lets them see public API changes for each PR very easily.

> Use sbt to detect new or changed public classes in PRs
> ------------------------------------------------------
>
>                 Key: SPARK-5312
>                 URL: https://issues.apache.org/jira/browse/SPARK-5312
>             Project: Spark
>          Issue Type: Improvement
>          Components: Project Infra
>            Reporter: Nicholas Chammas
>            Priority: Minor
>
> We currently use an [unwieldy grep/sed 
> contraption|https://github.com/apache/spark/blob/19556454881e05a6c2470d406d50f004b88088a2/dev/run-tests-jenkins#L152-L174]
>  to detect new public classes in PRs.
> Apparently, sbt lets you get a list of public classes [much more 
> directly|http://www.scala-sbt.org/0.13/docs/Howto-Inspect-the-Build.html] via 
> {{show compile:discoveredMainClasses}}. We should use that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to