[
https://issues.apache.org/jira/browse/SPARK-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357297#comment-14357297
]
Iulian Dragos commented on SPARK-6285:
--------------------------------------
According to the git commit message that introduced the duplicate:
{quote}
To avoid potential merge conflicts, old testing code are not removed yet. The
following classes can be safely removed after most Parquet related PRs are
handled:
- `ParquetQuerySuite`
- `ParquetTestData`
{quote}
I mentioned the Eclipse build problem in passing, but I can expand: the class
*is* a duplicated name, so the Scala compiler is correct in refusing it. It
only compiles in Sbt/Maven because the src/main and src/test are compiled in
separate compiler runs, and scalac seems to not notice the duplicate name when
it comes from bytecode. Eclipse builds src/main and src/test together, and when
both classes originate from sources scalac issues an error message.
> Duplicated code leads to errors
> -------------------------------
>
> Key: SPARK-6285
> URL: https://issues.apache.org/jira/browse/SPARK-6285
> Project: Spark
> Issue Type: Bug
> Components: SQL
> Affects Versions: 1.3.0
> Reporter: Iulian Dragos
>
> The following class is duplicated inside
> [ParquetTestData|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTestData.scala#L39]
> and
> [ParquetIOSuite|https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetIOSuite.scala#L44],
> with exact same code and fully qualified name:
> {code}
> org.apache.spark.sql.parquet.TestGroupWriteSupport
> {code}
> The second one was introduced in
> [3b395e10|https://github.com/apache/spark/commit/3b395e10510782474789c9098084503f98ca4830],
> but even though it mentions that `ParquetTestData` should be removed later,
> I couldn't find a corresponding Jira ticket.
> This duplicate class causes the Eclipse builder to fail (since src/main and
> src/test are compiled together in Eclipse, unlike Sbt).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
