[
https://issues.apache.org/jira/browse/SPARK-37935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624343#comment-17624343
]
Max Gekk edited comment on SPARK-37935 at 10/26/22 10:18 AM:
-------------------------------------------------------------
[~panbingkun] [~ivoson] [~xleesf] [~YActs] [~lvshaokang] [~kaifeiYi]
[~LuciferYang] There are still some error classes that are not covered by
tests. If you would like to write a test, please, open a sub-tasks in the
umbrella JIRA and ping me. also cc [~itholic] [~wenchen] Here is the list:
- CANNOT_INFER_DATE
- CONCURRENT_QUERY
- CONNECT.INTERCEPTOR_CTOR_MISSING
- CONNECT.INTERCEPTOR_RUNTIME_ERROR
- DATATYPE_MISMATCH.BINARY_ARRAY_DIFF_TYPES
- DATATYPE_MISMATCH.CANNOT_CONVERT_TO_JSON
- DATATYPE_MISMATCH.FRAME_LESS_OFFSET_WITHOUT_FOLDABLE
- DATATYPE_MISMATCH.MAP_FROM_ENTRIES_WRONG_TYPE
- DATATYPE_MISMATCH.NON_STRING_TYPE
- DATATYPE_MISMATCH.NULL_TYPE
- DATATYPE_MISMATCH.SPECIFIED_WINDOW_FRAME_DIFF_TYPES
- DATATYPE_MISMATCH.SPECIFIED_WINDOW_FRAME_UNACCEPTED_TYPE
- DATATYPE_MISMATCH.SPECIFIED_WINDOW_FRAME_WITHOUT_FOLDABLE
- DATATYPE_MISMATCH.UNSPECIFIED_FRAME
- DEFAULT_DATABASE_NOT_EXISTS
- FAILED_RENAME_PATH
- INDEX_ALREADY_EXISTS
- INDEX_NOT_FOUND
- MISSING_STATIC_PARTITION_COLUMN
- ROUTINE_NOT_FOUND
- TOO_MANY_ARRAY_ELEMENTS
- UNRESOLVED_FIELD.WITHOUT_SUGGESTION
- UNRESOLVED_MAP_KEY.WITHOUT_SUGGESTION
- UNSUPPORTED_FEATURE.DISTRIBUTE_BY
- UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.CORRELATED_COLUMN_NOT_FOUND
-
UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.UNSUPPORTED_CORRELATED_REFERENCE_DATA_TYPE
-
UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.UNSUPPORTED_CORRELATED_SCALAR_SUBQUERY
- UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.UNSUPPORTED_IN_EXISTS_SUBQUERY
was (Author: maxgekk):
[~panbingkun] [~ivoson] [~xleesf] [~YActs] [~lvshaokang] [~kaifeiYi]
[~LuciferYang] There are still some error classes that are not covered by
tests. If you would like to write a test, please, open a sub-tasks in the
umbrella JIRA and ping me. also cc [~itholic] [~wenchen] Here is the list:
- CANNOT_CAST_DATATYPE
- CANNOT_INFER_DATE
- CONCURRENT_QUERY
- CONNECT.INTERCEPTOR_CTOR_MISSING
- CONNECT.INTERCEPTOR_RUNTIME_ERROR
- DATATYPE_MISMATCH.BINARY_ARRAY_DIFF_TYPES
- DATATYPE_MISMATCH.CANNOT_CONVERT_TO_JSON
- DATATYPE_MISMATCH.FRAME_LESS_OFFSET_WITHOUT_FOLDABLE
- DATATYPE_MISMATCH.MAP_FROM_ENTRIES_WRONG_TYPE
- DATATYPE_MISMATCH.NON_STRING_TYPE
- DATATYPE_MISMATCH.NULL_TYPE
- DATATYPE_MISMATCH.SPECIFIED_WINDOW_FRAME_DIFF_TYPES
- DATATYPE_MISMATCH.SPECIFIED_WINDOW_FRAME_UNACCEPTED_TYPE
- DATATYPE_MISMATCH.SPECIFIED_WINDOW_FRAME_WITHOUT_FOLDABLE
- DATATYPE_MISMATCH.UNSPECIFIED_FRAME
- DEFAULT_DATABASE_NOT_EXISTS
- FAILED_RENAME_PATH
- INDEX_ALREADY_EXISTS
- INDEX_NOT_FOUND
- MISSING_STATIC_PARTITION_COLUMN
- ROUTINE_NOT_FOUND
- TOO_MANY_ARRAY_ELEMENTS
- UNRESOLVED_FIELD.WITHOUT_SUGGESTION
- UNRESOLVED_MAP_KEY.WITHOUT_SUGGESTION
- UNSUPPORTED_FEATURE.DISTRIBUTE_BY
- UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.CORRELATED_COLUMN_NOT_FOUND
-
UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.UNSUPPORTED_CORRELATED_REFERENCE_DATA_TYPE
-
UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.UNSUPPORTED_CORRELATED_SCALAR_SUBQUERY
- UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.UNSUPPORTED_IN_EXISTS_SUBQUERY
> Migrate onto error classes
> --------------------------
>
> Key: SPARK-37935
> URL: https://issues.apache.org/jira/browse/SPARK-37935
> Project: Spark
> Issue Type: Umbrella
> Components: Spark Core, SQL
> Affects Versions: 3.3.0
> Reporter: Max Gekk
> Assignee: Max Gekk
> Priority: Major
> Fix For: 3.4.0
>
>
> The PR https://github.com/apache/spark/pull/32850 introduced error classes as
> a part of the error messages framework
> (https://issues.apache.org/jira/browse/SPARK-33539). Need to migrate all
> exceptions from QueryExecutionErrors, QueryCompilationErrors and
> QueryParsingErrors on the error classes using instances of SparkThrowable,
> and carefully test every error class by writing tests in dedicated test
> suites:
> * QueryExecutionErrorsSuite for the errors that are occurred during query
> execution
> * QueryCompilationErrorsSuite ... query compilation or eagerly executing
> commands
> * QueryParsingErrorsSuite ... parsing errors
> Here is an example https://github.com/apache/spark/pull/35157 of how an
> existing Java exception can be replaced, and testing of related error
> classes.At the end, we should migrate all exceptions from the files
> Query.*Errors.scala and cover all error classes from the error-classes.json
> file by tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
