[
https://issues.apache.org/jira/browse/SPARK-45533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778917#comment-17778917
]
Min Zhao edited comment on SPARK-45533 at 10/24/23 4:12 AM:
------------------------------------------------------------
Thank you very much. [~LuciferYang]
In my opinion, the close method of RocksDB does not need to be adjusted. If
want to use cleanable.clean(), need to introduce new variables, which seems
unnecessary. I will submit a version for review first. If there is any
deviation in my understanding, please let me know.
Moreover, RocksDBIterator and LevelDBIterator have similar logic. I will submit
the code of RocksDBIterator first, which will make it easier to review and
improve.
was (Author: JIRAUSER293138):
Thank you very much. [~LuciferYang]
The close method of RocksDB does not need to be adjusted. If want to use
cleanable.clean(), need to introduce new variables, which seems unnecessary. I
will submit a version for review first. If there is any deviation in my
understanding, please let me know.
Moreover, RocksDBIterator and LevelDBIterator have similar logic. I will submit
the code of RocksDBIterator first, which will make it easier to review and
improve.
> Use `j.l.r.Cleaner` instead of `finalize` for
> `RocksDBIterator/LevelDBIterator`
> -------------------------------------------------------------------------------
>
> Key: SPARK-45533
> URL: https://issues.apache.org/jira/browse/SPARK-45533
> Project: Spark
> Issue Type: Sub-task
> Components: Spark Core
> Affects Versions: 4.0.0
> Reporter: Yang Jie
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
