Jiaan Geng created SPARK-45649:
----------------------------------

             Summary: Unified the prepare framework for 
`OffsetWindowFunctionFrame`
                 Key: SPARK-45649
                 URL: https://issues.apache.org/jira/browse/SPARK-45649
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 4.0.0
            Reporter: Jiaan Geng
            Assignee: Jiaan Geng


Currently, the implementation the `prepare` of  all the 
`OffsetWindowFunctionFrame` have the same code logic show below.
```
  override def prepare(rows: ExternalAppendOnlyUnsafeRowArray): Unit = {
    if (offset > rows.length) {
      fillDefaultValue(EmptyRow)
    } else {
      resetStates(rows)
      if (ignoreNulls) {
        ...
      } else {
        ...
      }
    }
  }
```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to