Gengliang Wang created SPARK-48035: -------------------------------------- Summary: try_add/try_multiply should not be semantic equal to add/multiply Key: SPARK-48035 URL: https://issues.apache.org/jira/browse/SPARK-48035 Project: Spark Issue Type: Bug Components: SQL Affects Versions: 4.0.0 Reporter: Gengliang Wang
In the current implementation, the following code will return true {code:java} val l1 = Literal(1) val l2 = Literal(2) val l3 = Literal(3) val expr1 = Add(Add(l1, l2), l3) val expr2 = Add(Add(l2, l1, EvalMode.TRY), l3) expr1.semanticEquals(expr2) {code} The same applies to Multiply. When creating MultiCommutativeOp for Add/Multiply, we should ensure all the evalMode are consistent. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org