[
https://issues.apache.org/jira/browse/SPARK-48068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun updated SPARK-48068:
----------------------------------
Description:
We assumed that `PYTHON_EXECUTABLE` is used for `dev/lint-python` like the
following. That's not true. We need to use `mypy`'s parameter to make it sure.
https://github.com/apache/spark/blob/ff401dde50343c9bbc1c49a0294272f2da7d01e2/.github/workflows/build_and_test.yml#L705
{code}
root@18c8eae5791e:/spark# PYTHON_EXECUTABLE=python3.9 mypy
--python-executable=python3.11 --namespace-packages --config-file
python/mypy.ini python/pyspark | wc -l
3428
root@18c8eae5791e:/spark# PYTHON_EXECUTABLE=python3.9 mypy --namespace-packages
--config-file python/mypy.ini python/pyspark | wc -l
1
root@18c8eae5791e:/spark# PYTHON_EXECUTABLE=python3.11 mypy
--namespace-packages --config-file python/mypy.ini python/pyspark | wc -l
1
{code}
was:
We assumed that `PYTHON_EXECUTABLE` is used for `dev/lint-python` like the
following. That's not true. We need to use `mypy`'s parameter to make it sure.
https://github.com/apache/spark/blob/ff401dde50343c9bbc1c49a0294272f2da7d01e2/.github/workflows/build_and_test.yml#L705
> `mypy` should have `--python-executable` parameter
> --------------------------------------------------
>
> Key: SPARK-48068
> URL: https://issues.apache.org/jira/browse/SPARK-48068
> Project: Spark
> Issue Type: Sub-task
> Components: Project Infra, PySpark
> Affects Versions: 3.3.0, 4.0.0, 3.5.1, 3.3.4, 3.4.3
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.5.2, 3.4.4
>
>
> We assumed that `PYTHON_EXECUTABLE` is used for `dev/lint-python` like the
> following. That's not true. We need to use `mypy`'s parameter to make it sure.
> https://github.com/apache/spark/blob/ff401dde50343c9bbc1c49a0294272f2da7d01e2/.github/workflows/build_and_test.yml#L705
> {code}
> root@18c8eae5791e:/spark# PYTHON_EXECUTABLE=python3.9 mypy
> --python-executable=python3.11 --namespace-packages --config-file
> python/mypy.ini python/pyspark | wc -l
> 3428
> root@18c8eae5791e:/spark# PYTHON_EXECUTABLE=python3.9 mypy
> --namespace-packages --config-file python/mypy.ini python/pyspark | wc -l
> 1
> root@18c8eae5791e:/spark# PYTHON_EXECUTABLE=python3.11 mypy
> --namespace-packages --config-file python/mypy.ini python/pyspark | wc -l
> 1
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
