[
https://issues.apache.org/jira/browse/SPARK-49647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun resolved SPARK-49647.
-----------------------------------
Fix Version/s: 4.0.0
Resolution: Fixed
Issue resolved by pull request 48111
[https://github.com/apache/spark/pull/48111]
> Pick up system property defaults in SharedSparkContext test suite mixin
> -----------------------------------------------------------------------
>
> Key: SPARK-49647
> URL: https://issues.apache.org/jira/browse/SPARK-49647
> Project: Spark
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 4.0.0
> Reporter: Josh Rosen
> Assignee: Josh Rosen
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
>
> The SharedSparkContext test suite mixin currently instantiates a SparkConf
> with `new SparkConf(false)`, which does not pick up defaults from system
> properties and thus misses certain test-default configurations and settings
> which are specified via test runner options in SBT or Maven; see
> [https://github.com/apache/spark/blob/08a26bb56cfb48f27c68a79be1e15bc4c9e466e0/core/src/test/scala/org/apache/spark/SharedSparkContext.scala#L30]
> and
> [https://github.com/apache/spark/blob/08a26bb56cfb48f27c68a79be1e15bc4c9e466e0/project/SparkBuild.scala#L1616-L1633]
> .
> As a consequence, a number of Spark's test suites are missing test-only
> defaults and this can adversely impact the performance and flakiness of those
> tests.
> I think that we should update SharedSparkContext to do `new SparkConf(true)`
> (a.k.a `new SparkConf()`) to address this problem. Note that most of our
> other test suites and mxins are already doing this, including
> SharedSparkSession in SparkSQL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
