[
https://issues.apache.org/jira/browse/SPARK-52825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karen Chen updated SPARK-52825:
-------------------------------
Issue Type: New Feature (was: Improvement)
> Additional dialect support
> --------------------------
>
> Key: SPARK-52825
> URL: https://issues.apache.org/jira/browse/SPARK-52825
> Project: Spark
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 4.0.0
> Reporter: Karen Chen
> Priority: Major
>
> h2. Context
> The [AWS Advanced JDBC
> Wrapper|[https://github.com/aws/aws-advanced-jdbc-wrapper|https://github.com/aws/aws-advanced-jdbc-wrapper.]]
> is a JDBC Wrapper driver that works in conjunction with existing community
> MySQL and PostgreSQL drivers, bringing additional smart enhanced
> functionality and enables new database features support.. It passes all of
> the JDBC method calls to the MySQL and PostgreSQL drivers database operations
> to the community drivers, the default MySQL or PostgreSQL dialects can be
> used with the wrapper.
> AWS Advanced JDBC Wrapper uses a different JDBC url protocol
> ("jdbc:aws-wrapper:mysql") instead of the MySQL Connector/J url protocol, so
> it fails MySQLDialect's canHandle check:
> https://github.com/apache/spark/blob/b9dcdde251d25dee284abe286b1d98e2f451c0db/sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala#L39
> The workaround is to create a custom JdbcDialect class, but since the
> MySQLDialect or PostgreSQLDialect are not extensible the resulting custom
> dialect classes have a lot of redundancy:
> [https://github.com/aws/aws-advanced-jdbc-wrapper/issues/1370#issuecomment-3047280187.]
> This impacts other drivers or wrappers based on existing community drivers as
> well.
> h2. Suggested Changes
> # What was the motivation for keeping these dialect classes private? Is it
> possible making them extendable?
> # Is the Spark team opened to us contributing new dialect classes for the
> AWS Advanced JDBC Wrapper?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
