[
https://issues.apache.org/jira/browse/SPARK-56325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081866#comment-18081866
]
Holden Karau commented on SPARK-56325:
--------------------------------------
still better to file and track :) ALthough you can use GH issues for light
weight things now.
> [SDP] Refactor FlowSystemMetadata.flowCheckpointsDirOpt to avoid scala.Option
> -----------------------------------------------------------------------------
>
> Key: SPARK-56325
> URL: https://issues.apache.org/jira/browse/SPARK-56325
> Project: Spark
> Issue Type: Improvement
> Components: Declarative Pipelines
> Affects Versions: 4.1.1
> Reporter: Jacek Laskowski
> Priority: Minor
> Labels: pull-request-available
>
> [FlowSystemMetadata.flowCheckpointsDirOpt()|https://github.com/apache/spark/blob/v4.1.1/sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/SystemMetadata.scala#L44]
> returns {{{}Option[Path]{}}}, but it makes no sense since it's either
> {{Some}} or an {{IllegalArgumentException}} exception is thrown.
> It makes more sense to return a {{Path}} instead (and throw an exception if
> needed).
> It will be less confusing (if not more readable) that {{{}None{}}}'s not an
> option (no pun intended).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
