[
https://issues.apache.org/jira/browse/SPARK-57140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084648#comment-18084648
]
Yicong Huang commented on SPARK-57140:
--------------------------------------
As a result, we cannot disable the merge button. Taking one step back,
currently we have both squash and rebase set to true. if we have to allow at
least one merge method, shall we keep one of them and disable the other one?
The merge button will still show up, though. cc [~dongjoon]
> Disable merge button in .asf.yaml
> ---------------------------------
>
> Key: SPARK-57140
> URL: https://issues.apache.org/jira/browse/SPARK-57140
> Project: Spark
> Issue Type: Improvement
> Components: Project Infra
> Affects Versions: 5.0.0
> Reporter: Yicong Huang
> Priority: Major
> Labels: pull-request-available
>
> Apache Spark merges pull requests exclusively through the
> {{dev/merge_spark_pr.py}} script, not through GitHub's web UI merge button.
> The current {{.asf.yaml}} still exposes the Squash and Rebase merge buttons
> ({{squash: true}}, {{rebase: true}}), which can mislead committers into
> merging a PR directly from the GitHub UI and bypassing the canonical merge
> tooling.
> This change disables all GitHub merge buttons in {{.asf.yaml}} ({{merge}},
> {{squash}}, {{rebase}} all set to {{false}}) so the only supported path to
> land a PR is the merge script.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
