[ 
https://issues.apache.org/jira/browse/SPARK-54203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Max Gekk resolved SPARK-54203.
------------------------------
    Fix Version/s: 4.3.0
       Resolution: Fixed

Issue resolved by pull request 56613
[https://github.com/apache/spark/pull/56613]

> Support TimeType in RowToColumnConverter
> ----------------------------------------
>
>                 Key: SPARK-54203
>                 URL: https://issues.apache.org/jira/browse/SPARK-54203
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 4.1.0
>            Reporter: Bruce Robbins
>            Assignee: Max Gekk
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.3.0
>
>
> h2. What
> Add a {{TimeType}} branch to {{RowToColumnConverter}} so rows containing TIME 
> columns can be
> converted to columnar (Arrow/columnar batch) format.
> h2. Why (confirmed needed)
> {{RowToColumnConverter.getConverterForType}} in
> {{sql/core/.../execution/Columnar.scala}} handles {{LongType | TimestampType |
> TimestampNTZType | DayTimeIntervalType}} (all long-backed) but has no 
> {{TimeType}} case, so
> a TIME column falls through to {{unsupportedDataTypeError}}. This blocks 
> row-to-column
> conversion paths (e.g. {{ColumnarToRow}}/{{RowToColumnar}} transitions, 
> vectorized
> execution) for TIME. (Supersedes the original "same change as TimestampNTZ in 
> commit
> 47276ab9902" note - the change is required, not speculative.)
> h2. Scope
> * Add the {{TimeType}} case to {{getConverterForType}} using the long-backed
>   ({{LongConverter}}) path, since TIME is stored as nanos-of-day {{Long}}.
> * Confirm the on/off-heap column vectors already round-trip TIME (they do - 
> TIME is in the
>   {{longData}} group).
> h2. Acceptance criteria
> * A DataFrame with a TIME column survives a row<->column round-trip (e.g. 
> cached columnar,
>   or a plan that inserts {{RowToColumnar}}).
> * Test added to {{ColumnarBatchSuite}} / the Columnar conversion tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to