[
https://issues.apache.org/jira/browse/SPARK-58948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18107119#comment-18107119
]
Uroš Bojanić commented on SPARK-58948:
--------------------------------------
In progress: https://github.com/apache/spark/pull/58228.
> Deduplicate nulls-buffer creation in columnar decompressors
> -----------------------------------------------------------
>
> Key: SPARK-58948
> URL: https://issues.apache.org/jira/browse/SPARK-58948
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 4.3.0
> Reporter: Uroš Bojanić
> Priority: Major
> Labels: pull-request-available
>
> Each columnar decompressor (PassThrough, RunLengthEncoding,
> DictionaryEncoding, BooleanBitSet, IntDelta, LongDelta) repeats the same
> two-line idiom to build the nulls buffer:
> buffer.duplicate().order(ByteOrder.nativeOrder()) followed by rewind(). This
> extracts a protected createNullsBuffer(buffer) helper on the shared Decoder
> trait and routes the six call sites through it. No behavior change; it also
> normalizes one site that called rewind without parentheses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
