Hyukjin Kwon created SPARK-59078:
------------------------------------
Summary: Fix master build broken by a semantic conflict between
SPARK-59075 and SPARK-59076 in observation.rs
Key: SPARK-59078
URL: https://issues.apache.org/jira/browse/SPARK-59078
Project: Spark
Issue Type: Bug
Components: Project Infra
Affects Versions: 5.0.0
Reporter: Hyukjin Kwon
master fails to compile in 'cargo test -p apache-spark-connect' (breaking Rust
build and test, Rust checks, WASM UDF feature, and the Coverage job) with:
error[E0599]: no method named set_metrics found for struct
observation::Observation
error[E0599]: no method named set_dataframe found for struct
observation::Observation
Root cause is a semantic merge conflict between two PRs that were each green in
isolation:
- SPARK-59075 added an inline #[cfg(test)] test in observation.rs that calls
the pub(crate) methods Observation::set_metrics / set_dataframe (which existed
at its base).
- SPARK-59076 removed those two methods as unused dead code (they had no
production callers).
Merged together, the test references methods that no longer exist. Fix: drop
the obsolete set_metrics_and_dataframe test. Re-adding the methods is wrong -
they are dead code with no callers, so they would reintroduce the dead_code
warning that SPARK-59076's deny(warnings) now rejects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
