[ 
https://issues.apache.org/jira/browse/SPARK-59137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hyukjin Kwon resolved SPARK-59137.
----------------------------------
    Fix Version/s: connect-rust-4.2.0
       Resolution: Fixed

Issue resolved by pull request 91
[https://github.com/apache/spark-connect-rust/pull/91]

> Update offline tests for the reference __module__ on catalog classes and 
> PythonEvalType (follow-up of SPARK-59117)
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-59137
>                 URL: https://issues.apache.org/jira/browse/SPARK-59137
>             Project: Spark
>          Issue Type: Improvement
>          Components: PySpark
>    Affects Versions: 5.0.0
>            Reporter: Hyukjin Kwon
>            Assignee: Hyukjin Kwon
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: connect-rust-4.2.0
>
>
> Follow-up of SPARK-59117, which set an explicit `__module__` on the PyO3 
> classes to the reference pyspark path (instead of the PyO3 default 
> "builtins").
> Two older offline tests in python/tests/test_dropin_offline.py still asserted 
> the pre-SPARK-59117 `__module__ == "builtins"` and now fail:
> - test_catalog_result_classes: CatalogMetadata / Database / Table / Function 
> / TablePartition now report `pyspark.sql.catalog`.
> - test_python_eval_type_constants: PythonEvalType now reports `pyspark.util`.
> Update both assertions to the reference module paths, consistent with the 
> tests SPARK-59117 added (test_class_module_matches_reference_path and the 
> test_no_pyclass_reports_builtins_module guard). Test-only change; no source 
> behavior change.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to