[
https://issues.apache.org/jira/browse/SPARK-59161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
L. C. Hsieh resolved SPARK-59161.
---------------------------------
Fix Version/s: connect-gateway-0.1.0
Resolution: Fixed
Issue resolved by pull request 17
[https://github.com/apache/spark-connect-gateway/pull/17]
> Run the Redis-backed integration tests in CI
> --------------------------------------------
>
> Key: SPARK-59161
> URL: https://issues.apache.org/jira/browse/SPARK-59161
> Project: Spark
> Issue Type: Sub-task
> Components: Connect
> Affects Versions: connect-gateway-0.1.0
> Reporter: L. C. Hsieh
> Assignee: L. C. Hsieh
> Priority: Major
> Labels: pull-request-available
> Fix For: connect-gateway-0.1.0
>
>
> The Redis-backed integration tests in scg-store-redis and scg-ratelimit are
> marked #[ignore = "requires Docker"], so `cargo test --workspace` skips them
> and
> they never ran in CI. That left 9 integration tests uncovered: the Redis
> AffinityStore round-trips (bind/resolve/forget, TTL expiry, atomic
> bind-if-absent, the op reverse index, two stores sharing one Redis) and the
> distributed token-bucket rate limiter (burst, refill, per-tenant isolation,
> two
> replicas sharing a bucket).
>
> These tests bring up their own Redis container through testcontainers, and the
> GitHub-hosted runners already provide a Docker daemon, so no extra service
> configuration is needed. This adds one CI step that runs them explicitly:
> cargo test -p scg-store-redis -p scg-ratelimit -- --ignored
> The #[ignore] markers stay, so a local `cargo test` still needs no Docker; CI
> opts in. Measured locally with Docker available: the 9 tests pass in about 10
> seconds including container startup, so the effect on CI time is small.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
