[
https://issues.apache.org/jira/browse/SPARK-59189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
L. C. Hsieh resolved SPARK-59189.
---------------------------------
Fix Version/s: connect-gateway-0.1.0
Resolution: Fixed
Issue resolved by pull request 18
[https://github.com/apache/spark-connect-gateway/pull/18]
> Run the proxy tracing integration test in CI
> --------------------------------------------
>
> Key: SPARK-59189
> URL: https://issues.apache.org/jira/browse/SPARK-59189
> Project: Spark
> Issue Type: Sub-task
> Components: Connect
> Affects Versions: connect-gateway-0.1.0
> Reporter: L. C. Hsieh
> Assignee: L. C. Hsieh
> Priority: Major
> Labels: pull-request-available
> Fix For: connect-gateway-0.1.0
>
>
> crates/proxy/tests/tracing_integration.rs verifies the gateway's OpenTelemetry
> behaviour end to end — that a forwarded RPC emits application spans and that
> the
> has never run in CI.
>
> The reason it must opt out of workspace-wide runs is a Cargo
> feature-unification
> effect, not a flaky test: `cargo test --workspace` puts `kube` in the
> dependency
> graph, which transitively enables `opentelemetry`'s
> spec_unstable_logs_enabled.
> The `tracing-opentelemetry` that then links silently drops application spans,
> so
> only h2-internal spans reach the in-memory exporter and the assertions fail.
> Built
> on its own the test passes. Verified both directions locally:
> cargo test -p scg-proxy --test tracing_integration -- --ignored -> 1
> passed
> cargo test --workspace --test tracing_integration -- --ignored -> FAILED
>
> The production gateway is unaffected, since it always builds the same way.
> This adds a step to the `integration` job (added in SPARK-59161) that runs the
> test with its own package-scoped cargo invocation, keeping the #[ignore]
> marker
> so workspace-wide runs stay reliable. The job is also renamed from
> "integration tests (Docker)" to "integration tests", since this test needs no
> Docker and the job now covers integration tests that simply need their own
> cargo
> invocation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
