[ 
https://issues.apache.org/jira/browse/SPARK-59994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yang Jie updated SPARK-59994:
-----------------------------
    Description: 
Whether a command evaluates its own expressions or only stores them (as 
metadata or source predicates) is decided by special-casing CreateVariable in 
two places: CheckAnalysis allows nondeterministic expressions only in 
CreateVariable among commands, and RewriteWithExpression (SPARK-59962) inlines 
common-expression definitions in every command except CreateVariable. A command 
from an extension, or a new one, that evaluates its expressions gets neither 
treatment and nothing points its author to these checks.

Make this a property of the command (for example a method on Command or a 
marker trait) that both rules read.

Raised in https://github.com/apache/spark/pull/59217#discussion_r4187715516


> Let a command declare that it evaluates its expressions, instead of 
> special-casing CreateVariable
> -------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-59994
>                 URL: https://issues.apache.org/jira/browse/SPARK-59994
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 5.0.0
>            Reporter: Yang Jie
>            Priority: Major
>
> Whether a command evaluates its own expressions or only stores them (as 
> metadata or source predicates) is decided by special-casing CreateVariable in 
> two places: CheckAnalysis allows nondeterministic expressions only in 
> CreateVariable among commands, and RewriteWithExpression (SPARK-59962) 
> inlines common-expression definitions in every command except CreateVariable. 
> A command from an extension, or a new one, that evaluates its expressions 
> gets neither treatment and nothing points its author to these checks.
> Make this a property of the command (for example a method on Command or a 
> marker trait) that both rules read.
> Raised in https://github.com/apache/spark/pull/59217#discussion_r4187715516



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to