[
https://issues.apache.org/jira/browse/SPARK-60853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
L. C. Hsieh resolved SPARK-60853.
---------------------------------
Fix Version/s: connect-gateway-0.1.0
Resolution: Fixed
Issue resolved by pull request 59
[https://github.com/apache/spark-connect-gateway/pull/59]
> Build with --locked in CI and the Dockerfile so Cargo.lock is enforced
> ----------------------------------------------------------------------
>
> Key: SPARK-60853
> URL: https://issues.apache.org/jira/browse/SPARK-60853
> Project: Spark
> Issue Type: Sub-task
> Components: Connect
> Affects Versions: connect-gateway-0.1.0
> Reporter: L. C. Hsieh
> Assignee: L. C. Hsieh
> Priority: Major
> Labels: pull-request-available
> Fix For: connect-gateway-0.1.0
>
>
> None of the cargo invocations in CI pass --locked: clippy, build and test in
> ci.yml, the ignored integration tests and the drain/HA smoke examples. Neither
> does the release build in the Dockerfile, which the e2e jobs also use.
> Without --locked, cargo silently re-resolves on the runner when Cargo.lock is
> inconsistent with the manifests (for example, a stale dependency list or a
> version that does not satisfy a requirement) and the job still passes, so a
> broken Cargo.lock can be merged without CI noticing.
> For the Dockerfile this also matters for the release: without --locked, the
> dependency versions in the published image are not guaranteed to match the
> Cargo.lock in the source release.
> Add --locked to every cargo build / test / clippy / run invocation in
> .github/workflows/ci.yml and to the cargo build in the Dockerfile.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
