[
https://issues.apache.org/jira/browse/SPARK-61004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SPARK-61004:
-----------------------------------
Labels: pull-request-available (was: )
> Extract shared SHOW command analysis helpers
> --------------------------------------------
>
> Key: SPARK-61004
> URL: https://issues.apache.org/jira/browse/SPARK-61004
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 5.0.0
> Reporter: Vladan Vasić
> Priority: Minor
> Labels: pull-request-available
>
> The analyzer currently keeps namespace resolution in ResolveCatalogs and SHOW
> listing command lowering in ResolveSessionCatalog. The legacy first-column
> rename is also repeated by KeepLegacyOutputs and the SHOW TABLE EXTENDED
> lowering path.
> Extract these responsibilities into reusable internal helpers and keep the
> existing rules as callers:
> * Extend CatalogIdentifierResolution with current and explicit namespace
> resolution, preserving catalog routing and optional metadata loading.
> * Extract SHOW TABLES, SHOW TABLE EXTENDED, SHOW VIEWS and SHOW FUNCTIONS
> lowering into ShowCommandHelper.
> * Share the legacy SHOW TABLES database-column rename without changing output
> expression IDs.
> This is a behavior-preserving refactor. V1 configuration guards, namespace
> validation order, ViewCatalog routing, errors and output schemas remain
> unchanged. It adds no SQL features or configuration.
> Validation covers current versus explicit catalog-root namespaces, namespace
> metadata loading, origin/tag preservation, V1 namespace errors, V2/unresolved
> targets, legacy output schemas and output expression IDs. Existing SHOW
> command suites and SQL goldens provide integration coverage.
> Local validation with JDK 21: 7 Catalyst CatalogSuite tests, 3 focused
> PlanResolutionSuite tests, 159 V1/V2 SHOW tests, 6 SQL execution/analyzer
> golden cases, and 98 Hive SHOW tests passed (273 total). No generated golden
> outputs changed.
> Catalyst and SQL production/test scalastyle checks passed with zero errors or
> warnings. Whitespace, changed-file line-length and ASCII checks passed.
> The available artifact mirror returned HTTP 403 for the unrelated
> net.snowflake:snowflake-jdbc-thin:4.4.1 test driver. SQL/Hive validation
> excluded only this driver through a temporary SBT setting; the committed
> dependency configuration is unchanged.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
