Hyukjin Kwon created SPARK-61230:
------------------------------------
Summary: Leave the files vendored from upstream out of the Python
coverage, and check that every vendored file is omitted
Key: SPARK-61230
URL: https://issues.apache.org/jira/browse/SPARK-61230
Project: Spark
Issue Type: Test
Components: Connect
Affects Versions: connect-rust-4.3.0
Reporter: Hyukjin Kwon
python/.coveragerc measures the hand-written Python of the drop-in and omits
the files vendored verbatim from Apache Spark (covered by Apache's own tests),
and says to keep its omit list in sync with the VENDORED_DIRS/VENDORED_FILES of
scripts/check_vendored_upstream.sh. Seven vendored files were still measured:
conf.py, taskcontext.py, traceback_utils.py, sql/geo_utils.py,
sql/sql_formatter.py, sql/connect/profiler.py and
sql/connect/shell/progress.py, with 281 of the 578 measured units they hold
uncovered. Omit them, and add a unit test (run by the lint workflow's
scripts/tests step) that fails when a vendored Python file is measured.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
