Hyukjin Kwon created SPARK-61236:
------------------------------------

             Summary: Declare the minimum supported Rust of the published 
crates as 1.88, which their dependencies need, and check it in CI
                 Key: SPARK-61236
                 URL: https://issues.apache.org/jira/browse/SPARK-61236
             Project: Spark
          Issue Type: Improvement
          Components: Connect
    Affects Versions: connect-rust-4.3.0
            Reporter: Hyukjin Kwon


docs/installation.md says "Rust 1.70 or later" and the workspace Cargo.toml 
says rust-version = "1.82", which none of the published crates inherits. The 
dependencies need more: tonic, tonic-prost and tonic-build 0.14.6 (and 
DataFusion 53 of the datafusion feature) declare rust-version 1.88, so the 
crates cannot build with an older Rust, and nothing checks the claim. Declare 
1.88 in the published crates (rust-version.workspace = true), document it, and 
add a CI job that runs cargo check of the published crates with Rust 1.88.




--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to