[
https://issues.apache.org/jira/browse/SPARK-61626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SPARK-61626:
-----------------------------------
Labels: pull-request-available (was: )
> Make clippy a blocking CI gate of spark-connect-rust
> ----------------------------------------------------
>
> Key: SPARK-61626
> URL: https://issues.apache.org/jira/browse/SPARK-61626
> Project: Spark
> Issue Type: Improvement
> Components: Connect
> Affects Versions: connect-rust-4.3.0
> Reporter: L. C. Hsieh
> Priority: Major
> Labels: pull-request-available
> Fix For: connect-rust-4.3.0
>
>
> The clippy step of .github/workflows/lint.yml runs `cargo clippy --workspace
> --all-targets || true`, so clippy findings never fail CI, and the tree has
> accumulated several hundred of them. The step does not even reach the lints
> today: `--workspace` builds examples/wasm-udfs (a path dependency of the
> `examples` member), whose build script needs the wasm32-unknown-unknown
> target that the lint job does not install, and `|| true` hides that failure
> too.
> Make clippy a blocking gate, as rustfmt, ruff, the coverage floors and the
> generated-file drift check already are:
> * allow the lints this codebase triggers by design (too_many_arguments,
> result_large_err, field_reassign_with_default, should_implement_trait) once,
> with a reason, in [workspace.lints.clippy] of the root Cargo.toml, inherited
> by every member;
> * fix the remaining findings;
> * install the wasm32 target in the lint job and run `cargo clippy --workspace
> --all-targets -- -D warnings`;
> * update the documents that describe clippy as advisory (AGENTS.md,
> docs/contributing.md).
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]