[ 
https://issues.apache.org/jira/browse/SPARK-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554629#comment-14554629
 ] 

Xiangrui Meng edited comment on SPARK-7535 at 5/22/15 6:17 AM:
---------------------------------------------------------------

Some notes:

In PR #6322:

1. Estimator/Transformer/ doesn’t need to extend Params since PipelineStage 
already does.
1. Move Evaluator to ml.evaluation.
1. Mention larger metrics are better.
1. PipelineModel doc. “compiled” -> “fitted”
1. Hide PolynomialExpansion.expand
1. Hide VectorAssembler.
1. Word2Vec.minCount -> @param
1. ParamValidators -> DeveloperApi
1. Hide MetadataUtils/SchemaUtils.

Others:

1. @varargs to setDefault (SPARK-7498)

1. Update RegexTokenizer default setting. (SPARK-7794)
1. Mention `RegexTokenizer` in `Tokenizer`. (SPARK-7794)

1. Remove Params.validateParams(paramMap)?

1. param and getParam should be final (SPARK-7816)

1. UnresolvedAttribute (Java compatibility?)
1. Missing RegressionEvaluator (SPARK-7404)
1. ml.feature missing package doc (SPARK-7808)

1. ALS -> use dataframes to store user/item factors? Then we can hide ALS.Rating
1. ALSModel -> remove training parameters?



was (Author: mengxr):
Some notes:

1. Estimator/Transformer/ doesn’t need to extend Params since PipelineStage 
already does.
2. @varargs to setDefault (SPARK-7498)
3. Move Evaluator to ml.evaluation.
4. Mention larger metrics are better.
5. PipelineModel doc. “compiled” -> “fitted”
6. Remove Params.validateParams(paramMap)?
7. UnresolvedAttribute (Java compatibility?)
8. Missing RegressionEvaluator (SPARK-7404)
9. ml.feature missing package doc (SPARK-7808)
10. param and getParam should be final (SPARK-7816)
11. Hide PolynomialExpansion.expand
12. Update RegexTokenizer default setting. (SPARK-7794)
13. Mention `RegexTokenizer` in `Tokenizer`. (SPARK-7794)
14. Hide VectorAssembler.
15. Word2Vec.minCount -> @param
16. ParamValidators -> DeveloperApi
17. Params -> @DeveloperApi
18. ALS -> use dataframes to store user/item factors? Then we can hide 
ALS.Rating
19. ALSModel -> remove training parameters?
20. Hide MetadataUtils/SchemaUtils.

> Audit Pipeline APIs for 1.4
> ---------------------------
>
>                 Key: SPARK-7535
>                 URL: https://issues.apache.org/jira/browse/SPARK-7535
>             Project: Spark
>          Issue Type: Sub-task
>          Components: ML, PySpark
>            Reporter: Joseph K. Bradley
>            Assignee: Xiangrui Meng
>
> This is an umbrella for auditing the Pipeline (spark.ml) APIs.  Items to 
> check:
> * Public/protected/private access
> * Consistency across spark.ml
> * Classes, methods, and parameters in spark.mllib but missing in spark.ml
> ** We should create JIRAs for each of these (under an umbrella) as to-do 
> items for future releases.
> For each algorithm or API component, create a subtask under this umbrella.  
> Some major new items:
> * new feature transformers
> * tree models
> * elastic-net
> * ML attributes
> * developer APIs (Predictor, Classifier, Regressor)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to