[
https://issues.apache.org/jira/browse/SPARK-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562133#comment-14562133
]
Joseph K. Bradley edited comment on SPARK-7529 at 5/28/15 6:57 PM:
-------------------------------------------------------------------
*spark.ml: Here is a list of issues found in a pass through the spark.ml
package.*
h3. Most important (Try to fix for 1.4)
BooleanParam + others
* ParamPair<Object> w(boolean value)
** *no description!* (doc not inherited in Java docs)
** Use Java types?
h3. Attributes (DeveloperApi; fix in next release)
Attribute.index (and subclasses)
* abstract scala.Option<Object> index()
AttributeGroup
* scala.Option<Object> numAttributes()
NominalAttribute+NumericAttribute constructors
* NominalAttribute(scala.Option<String> name, scala.Option<Object> index,
scala.Option<Object> isOrdinal, scala.Option<Object> numValues,
scala.Option<String[]> values)
* corresponding accessors have same problem
h3. Minor issues (probably OK)
Param + subclasses _--> Developer Api, but add Java test for Spark 1.5_
* Param(String parent, String name, String doc, scala.Function1<T,Object>
isValid)
* scala.Function1<T,Object> isValid()
* (same issue with ParamValidators)
h3. False positives _(saved here for posterity)_
OneVsRestModel
* Object models() _false positive (doc gen issue)_
CrossValidatorModel
* Object bestModel() _false positive (doc gen issue)_
Params _(These are OK; tested in Java.)_
* Param<Object> getParam(String paramName)
* Params set(String param, Object value)
was (Author: josephkb):
*spark.ml: Here is a list of issues found in a pass through the spark.ml
package.*
h3. Most important (Try to fix for 1.4)
BooleanParam + others
* ParamPair<Object> w(boolean value)
** *no description!* (doc not inherited in Java docs)
h3. Attributes (DeveloperApi; fix in next release)
Attribute.index (and subclasses)
* abstract scala.Option<Object> index()
AttributeGroup
* scala.Option<Object> numAttributes()
NominalAttribute+NumericAttribute constructors
* NominalAttribute(scala.Option<String> name, scala.Option<Object> index,
scala.Option<Object> isOrdinal, scala.Option<Object> numValues,
scala.Option<String[]> values)
* corresponding accessors have same problem
h3. Minor issues (probably OK)
Param + subclasses _--> Developer Api, but add Java test for Spark 1.5_
* Param(String parent, String name, String doc, scala.Function1<T,Object>
isValid)
* scala.Function1<T,Object> isValid()
* (same issue with ParamValidators)
h3. False positives _(saved here for posterity)_
OneVsRestModel
* Object models() _false positive (doc gen issue)_
CrossValidatorModel
* Object bestModel() _false positive (doc gen issue)_
Params _(These are OK; tested in Java.)_
* Param<Object> getParam(String paramName)
* Params set(String param, Object value)
> Java compatibility check for MLlib 1.4
> --------------------------------------
>
> Key: SPARK-7529
> URL: https://issues.apache.org/jira/browse/SPARK-7529
> Project: Spark
> Issue Type: Sub-task
> Components: ML, MLlib
> Affects Versions: 1.4.0
> Reporter: Xiangrui Meng
> Assignee: Joseph K. Bradley
>
> Check Java compatibility for MLlib 1.4. We should create separate JIRAs for
> each possible issue.
> Checking compatibility means:
> * comparing with the Scala doc
> * verifying that Java docs are not messed up by Scala type incompatibilities
> (E.g., check for generic "Object" types where Java cannot understand complex
> Scala types. Also check Scala objects (especially with nesting!) carefully.
> * If needed for complex issues, create small Java unit tests which execute
> each method. (The correctness can be checked in Scala.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
