[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593090#comment-14593090
]
Yu Ishikawa commented on SPARK-6813:
------------------------------------
[~shivaram] sounds interesting! I created a prototype script to check R files
with lintr. Let's talk about the rules to check R files.
https://github.com/yu-iskw/spark/commit/8da1d052ea3d903694dfce350587c74645661885
By the way, I couldn't pass the some R files with the default rules. The errors
raised.
{noformat}
> ./dev/lint-r
Error in body(fun) : object 'fun' not found
Calls: lint_package ... lapply -> FUN -> <Anonymous> -> findLocalsList -> body
Execution halted
{noformat}
> SparkR style guide
> ------------------
>
> Key: SPARK-6813
> URL: https://issues.apache.org/jira/browse/SPARK-6813
> Project: Spark
> Issue Type: New Feature
> Components: SparkR
> Reporter: Shivaram Venkataraman
>
> We should develop a SparkR style guide document based on the some of the
> guidelines we use and some of the best practices in R.
> Some examples of R style guide are:
> http://r-pkgs.had.co.nz/r.html#style
> http://google-styleguide.googlecode.com/svn/trunk/google-r-style.html
> A related issue is to work on a automatic style checking tool.
> https://github.com/jimhester/lintr seems promising
> We could have a R style guide based on the one from google [1], and adjust
> some of them with the conversation in Spark:
> 1. Line Length: maximum 100 characters
> 2. no limit on function name (API should be similar as in other languages)
> 3. Allow S4 objects/methods
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
