[
https://issues.apache.org/jira/browse/SPARK-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606928#comment-14606928
]
Josh Rosen commented on SPARK-8722:
-----------------------------------
Also, this feature needs to block on being able to pass GitHub OAuth tokens to
the merge script in order to make authenticated GitHub requests; if we don't do
this, we'll quickly hit the IP limit at the Databricks office.
> PR merge script should warn when merging a PR that has failed tests
> -------------------------------------------------------------------
>
> Key: SPARK-8722
> URL: https://issues.apache.org/jira/browse/SPARK-8722
> Project: Spark
> Issue Type: New Feature
> Components: Project Infra
> Reporter: Josh Rosen
>
> It would be helpful if our PR merge script looked at the GitHub comments and
> warned the committer if the PR being merged had failed its most recent test
> run. It might also be nice to log a warning if the PR was last tested more
> than X days ago, since a PR that hasn't recently been tested might be failing
> new style checks or other tests. We should provide an option to continue and
> force-merge despite the test failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
