[ 
https://issues.apache.org/jira/browse/SPARK-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609627#comment-14609627
 ] 

Cheng Hao commented on SPARK-8653:
----------------------------------

Yes, I agree that we cannot make a clear cut, as people can code the expression 
in their faviorate way.

I am wondering if we can merge my PR first, at least it works for the correct 
data casting, so we can finish the Hive Expression rewriting job ASAP. And we 
can refactor the code whenever we have a better idea to simplify that.

> Add constraint for Children expression for data type
> ----------------------------------------------------
>
>                 Key: SPARK-8653
>                 URL: https://issues.apache.org/jira/browse/SPARK-8653
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Cheng Hao
>            Assignee: Reynold Xin
>
> Currently, we have trait in Expression like `ExpectsInputTypes` and also the 
> `checkInputDataTypes`, but can not convert the children expressions 
> automatically, except we write the new rules in the `HiveTypeCoercion`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to