Feynman Liang created SPARK-8799:
------------------------------------

             Summary: OneVsRestModel should extend ClassificationModel
                 Key: SPARK-8799
                 URL: https://issues.apache.org/jira/browse/SPARK-8799
             Project: Spark
          Issue Type: Improvement
          Components: ML
            Reporter: Feynman Liang
            Priority: Minor


Many parts of `OneVsRestModel` can be generalized to `ClassificationModel`. For 
example:
 * `accColName` can be used to populate `ClassificationModel#predictRaw` and 
share implementations of `transform`
 * SPARK-8092 adds `setFeaturesCol` and `setPredictionCol` which could be 
gotten for free through subclassing

`ClassificationModel` is the correct supertype (e.g. not `PredictionModel`) 
because the labels for a `OneVsRest` will always be discrete and finite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to