[
https://issues.apache.org/jira/browse/SPARK-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613308#comment-14613308
]
Sean Owen commented on SPARK-8815:
----------------------------------
Hm, where in the JLS do you see that? I couldn't find it after a quick look,
though I agree javac seems to reject it, but that may not be 100% the same as
saying the JVM rejects it. This package never goes through compilation; it's
the result of a renaming during the build process. Since the result does work,
that's why I wonder whether it's actually valid. (Nobody would ever import this
class.)
> illegal java package names in jar
> ---------------------------------
>
> Key: SPARK-8815
> URL: https://issues.apache.org/jira/browse/SPARK-8815
> Project: Spark
> Issue Type: Bug
> Reporter: Sam Halliday
>
> In ENSIME we were unable to index the spark jars and we investigated
> further... you have classes that look like this:
> org.spark-project.guava.annotations.VisibleForTesting
> Hyphens are not legal package names according to the java language spec, so
> I'm amazed that this can actually be read at runtime... certainly no compiler
> I know would allow it.
> What I suspect is happening is that you're using a build plugin that
> internalises some of your dependencies and it is using your groupId but not
> validating it... and then blindly using that name in the ASM manipulation.
> You might want to report this upstream with your build plugin.
> For your next release, I recommend using an explicit name that is not your
> groupId. i.e. convert hyphens to underscores as Gosling recommends.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
