Josh Rosen created SPARK-8932:
---------------------------------
Summary: Support copy in UnsafeRow as long as ObjectPool is not
used
Key: SPARK-8932
URL: https://issues.apache.org/jira/browse/SPARK-8932
Project: Spark
Issue Type: New Feature
Components: SQL
Reporter: Josh Rosen
Assignee: Josh Rosen
We call {{InternalRow.copy()}} in many places throughout SQL but UnsafeRow
currently throws UnsupportedOperationException when copy() is called.
Supporting copying when ObjectPool is used may be difficult, since we may need
to handle deep-copying of objects in the pool. In addition, this copy() method
needs to produce a self-contained row object which may be passed around /
buffered by downstream code which does not understand the UnsafeRow format.
In the long run, we'll need to figure out how to handle the ObjectPool corner
cases, but this may be unnecessary if other changes are made. Therefore, in
order to unblock my sort patch I propose that we support copy() for the cases
where UnsafeRow does not use an ObjectPool and continue to throw
UnsupportedOperationException when an ObjectPool is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
