[
https://issues.apache.org/jira/browse/SPARK-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622542#comment-14622542
]
Nicholas Chammas commented on SPARK-8960:
-----------------------------------------
Style cleanup is OK, but should be preferably done at the same time as
something more significant, like a refactoring of some part of the code, or
adding new features or bug fixes.
A PR just to clean up minor style issues is probably not needed (feel free to
make the case otherwise), since the script is already PEP 8-compliant and thus
meets a minimal level of consistency and good style.
A PR towards reorganizing the script (per the [dev list
discussion|http://mail-archives.apache.org/mod_mbox/incubator-spark-dev/201507.mbox/%3CCAOhmDzcnYgswssNP11VbGzSLisOKjGfnuMQMQc7yHiDL5SusmA%40mail.gmail.com%3E])
or adding tests for spark-ec2 (as Daniel mentioned) is probably much more
valuable.
> Style cleanup of spark_ec2.py
> -----------------------------
>
> Key: SPARK-8960
> URL: https://issues.apache.org/jira/browse/SPARK-8960
> Project: Spark
> Issue Type: Task
> Components: EC2
> Affects Versions: 1.4.0
> Reporter: Daniel Darabos
> Priority: Trivial
>
> The spark_ec2.py script could use some cleanup I think. There are simple
> style issues like mixing single and double quotes, but also some rather
> un-Pythonic constructs (e.g.
> https://github.com/apache/spark/pull/6336#commitcomment-12088624 that sparked
> this JIRA). Whenever I read it, I always find something that is too minor for
> a pull request/JIRA, but I'd fix it if it was my code. Perhaps we can address
> such issues in this JIRA.
> The intention is not to introduce any behavioral changes. It's hard to verify
> this without testing, so perhaps we should also add some kind of test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
