[
https://issues.apache.org/jira/browse/SPARK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joseph K. Bradley updated SPARK-9073:
-------------------------------------
Shepherd: Joseph K. Bradley
> spark.ml Models copy() should call setParent when there is a parent
> -------------------------------------------------------------------
>
> Key: SPARK-9073
> URL: https://issues.apache.org/jira/browse/SPARK-9073
> Project: Spark
> Issue Type: Bug
> Components: ML
> Affects Versions: 1.5.0
> Reporter: Joseph K. Bradley
> Assignee: Kai Sasaki
> Priority: Minor
>
> Examples with this mistake include:
> *
> [https://github.com/apache/spark/blob/9716a727fb2d11380794549039e12e53c771e120/mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala#L119]
> *
> [https://github.com/apache/spark/blob/9716a727fb2d11380794549039e12e53c771e120/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L220]
> Whomever writes a PR for this JIRA should check all spark.ml Model's copy()
> methods and set copy's {{Model.parent}} when available. Also verify in unit
> tests (possibly in a standard method checking Models to share code).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
