[ 
https://issues.apache.org/jira/browse/SPARK-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reynold Xin updated SPARK-9150:
-------------------------------
    Description: 
It is very hard to track which expression supports code generation or not. This 
patch removes the default gencode implementation from Expression, and moves the 
default fallback implementation into a new trait called CodegenFallback. Each 
concrete expression needs to either implement code generation, or mix in 
CodegenFallback. This makes it very easy to track which expressions have code 
generation implemented already.

Additionally, this patch creates an Unevaluable trait that can be used to track 
expressions that don't support evaluation (e.g. Star).


  was:
It is very hard to track which expression supports code generation or not. This 
patch removes the default gencode implementation from Expression, and moves the 
default fallback implementation into a new trait called CodegenFallback. Each 
concrete expression needs to either implement code generation, or mix in 
CodegenFallback.

This makes it very easy to track which expressions have code generation 
implemented already.



> Create CodegenFallback and Unevaluable trait
> --------------------------------------------
>
>                 Key: SPARK-9150
>                 URL: https://issues.apache.org/jira/browse/SPARK-9150
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Reynold Xin
>            Assignee: Reynold Xin
>            Priority: Critical
>
> It is very hard to track which expression supports code generation or not. 
> This patch removes the default gencode implementation from Expression, and 
> moves the default fallback implementation into a new trait called 
> CodegenFallback. Each concrete expression needs to either implement code 
> generation, or mix in CodegenFallback. This makes it very easy to track which 
> expressions have code generation implemented already.
> Additionally, this patch creates an Unevaluable trait that can be used to 
> track expressions that don't support evaluation (e.g. Star).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to