[
https://issues.apache.org/jira/browse/SPARK-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638547#comment-14638547
]
François Garillot commented on SPARK-9267:
------------------------------------------
I see a *lot* of [string
interpolation|http://docs.scala-lang.org/overviews/core/string-interpolation.html]
uses in the codebase (grepping {{'\bs\".*?\"'}}), hinting at how this is
probably a well-accepted alternative to {{.format()}} inlining. Should be
easier to read.
> Remove highly unnecessary accumulators stringify methods
> --------------------------------------------------------
>
> Key: SPARK-9267
> URL: https://issues.apache.org/jira/browse/SPARK-9267
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
> Affects Versions: 1.0.0
> Reporter: Andrew Or
> Priority: Trivial
>
> {code}
> def stringifyPartialValue(partialValue: Any): String =
> "%s".format(partialValue)
> def stringifyValue(value: Any): String = "%s".format(value)
> {code}
> These are only used in 1 place (DAGScheduler). The level of indirection
> actually makes the code harder to read without an editor. We should just
> inline them...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
