[
https://issues.apache.org/jira/browse/SPARK-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659182#comment-14659182
]
Joseph K. Bradley commented on SPARK-9658:
------------------------------------------
1 was intentional. I'm OK with creating a new param though.
2. gammaShape could be given a default. topicConcentration is necessary, I'd
say.
3. AFAIK this is a Scala compiler bug, not something we can fix easily.
4. That was intentional. We could put it back, though that would create
duplicate parameters with sort of confusing semantics.
5. Sounds good.
> Binary incompatible changes in MLlib 1.5
> ----------------------------------------
>
> Key: SPARK-9658
> URL: https://issues.apache.org/jira/browse/SPARK-9658
> Project: Spark
> Issue Type: Umbrella
> Components: ML, MLlib
> Affects Versions: 1.5.0
> Reporter: Xiangrui Meng
> Assignee: Xiangrui Meng
> Priority: Blocker
>
> Generated a list of binary incompatible changes using MiMa and filter out
> some false positives:
> 1. LDA.docConcentration
> It will be nice to keep the old APIs unchanged. For example, we can use
> “asymmetricDocConcentration”. Then “getDocConcentration" would return the
> first item if the concentration vector is a constant vector.
> 2. LDAModel.gammaShape / topicConcentration
> Should be okay if we assume that no one extends LDAModel.
> 3. Params.setDefault
> If we have time to investigate this issue. We should put it back.
> 4. LogisticRegressionModel.threshold is missing.
> 5. LogisticRegression.setThreshold shouldn't be in the Params trait. We need
> to override it anyway.
> Will create sub-tasks for each item.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
