Joseph K. Bradley created SPARK-9847:
----------------------------------------

             Summary: ML Params copyValues should copy default values to 
default map, not set map
                 Key: SPARK-9847
                 URL: https://issues.apache.org/jira/browse/SPARK-9847
             Project: Spark
          Issue Type: Improvement
          Components: ML
            Reporter: Joseph K. Bradley
            Assignee: Joseph K. Bradley
            Priority: Critical


Currently, Params.copyValues copies default parameter values to the paramMap of 
the target instance, rather than the defaultParamMap.  It should copy to the 
defaultParamMap because explicitly setting a parameter can change the semantics.

This issue arose in [SPARK-9789], where 2 params "threshold" and "thresholds" 
for LogisticRegression can have mutually exclusive values.  If thresholds is 
set, then fit() will copy the default value of threshold as well, easily 
resulting in inconsistent settings for the 2 params.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to