Michel Lemay created SPARK-9886:
-----------------------------------

             Summary: Validate usages of Runtime.getRuntime.addShutdownHook
                 Key: SPARK-9886
                 URL: https://issues.apache.org/jira/browse/SPARK-9886
             Project: Spark
          Issue Type: Bug
          Components: Spark Core
            Reporter: Michel Lemay
            Priority: Minor


While refactoring calls to Utils.addShutdownHook to spark ShutdownHookManager 
in PR #8109, I've seen instances of calls to Runtime.getRuntime.addShutdownHook:

org\apache\spark\deploy\ExternalShuffleService.scala:126
org\apache\spark\deploy\mesos\MesosClusterDispatcher.scala:113
org\apache\spark\storage\ExternalBlockStore.scala:181

Comment from @vanzin:
"From a quick look, it seems that at least the one in ExternalBlockStore should 
be changed; the other two seem to be separate processes (i.e. they are not part 
of a Spark application) so that's questionable. But I'd say leave it for a 
different change (maybe file a separate bug so it doesn't fall through the 
cracks)."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to