[ 
https://issues.apache.org/jira/browse/SPARK-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiangrui Meng updated SPARK-11337:
----------------------------------
    Description: 
The example code in the user guide is embedded in the markdown and hence it is 
not easy to test. It would be nice to automatically test them. This JIRA is to 
discuss options to automate example code testing and see what we can do in 
Spark 1.6.

One option I propose is to move actual example code to spark/examples and test 
compilation in Jenkins builds. Then in the markdown, we can reference part of 
the code to show in the user guide. This requires adding a Jekyll tag that is 
similar to 
https://github.com/jekyll/jekyll/blob/master/lib/jekyll/tags/include.rb, e.g., 
called include_example.

{code}
{% include_example scala ml.KMeansExample guide %}
{code}

Jekyll will find 
`examples/src/main/scala/org/apache/spark/examples/ml/KMeansExample.scala` and 
pick code blocks marked "example" and put them under `{% highlight %}` in the 
markdown. We can discuss the syntax for marker comments.

Sub-tasks are created to move example code from user guide to `examples/`.

  was:
The example code in the user guide is embedded in the markdown and hence it is 
not easy to test. It would be nice to automatically test them. This JIRA is to 
discuss options to automate example code testing and see what we can do in 
Spark 1.6.

One option I propose is to move actual example code to spark/examples and test 
compilation in Jenkins builds. Then in the markdown, we can reference part of 
the code to show in the user guide. This requires adding a Jekyll tag that is 
similar to 
https://github.com/jekyll/jekyll/blob/master/lib/jekyll/tags/include.rb, e.g., 
called include_example.

{code}
{% include_example scala ml.KMeansExample guide %}
{code}

Jekyll will find 
`examples/src/main/scala/org/apache/spark/examples/ml/KMeansExample.scala` and 
pick code blocks marked "guide" and put them under `{% highlight %}` in the 
markdown. We can discuss the syntax for marker comments.

Just one way to implement this. It would be nice to hear more ideas.


> Make example code in user guide testable
> ----------------------------------------
>
>                 Key: SPARK-11337
>                 URL: https://issues.apache.org/jira/browse/SPARK-11337
>             Project: Spark
>          Issue Type: Umbrella
>            Reporter: Xiangrui Meng
>            Assignee: Xusen Yin
>            Priority: Critical
>
> The example code in the user guide is embedded in the markdown and hence it 
> is not easy to test. It would be nice to automatically test them. This JIRA 
> is to discuss options to automate example code testing and see what we can do 
> in Spark 1.6.
> One option I propose is to move actual example code to spark/examples and 
> test compilation in Jenkins builds. Then in the markdown, we can reference 
> part of the code to show in the user guide. This requires adding a Jekyll tag 
> that is similar to 
> https://github.com/jekyll/jekyll/blob/master/lib/jekyll/tags/include.rb, 
> e.g., called include_example.
> {code}
> {% include_example scala ml.KMeansExample guide %}
> {code}
> Jekyll will find 
> `examples/src/main/scala/org/apache/spark/examples/ml/KMeansExample.scala` 
> and pick code blocks marked "example" and put them under `{% highlight %}` in 
> the markdown. We can discuss the syntax for marker comments.
> Sub-tasks are created to move example code from user guide to `examples/`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to