[ 
https://issues.apache.org/jira/browse/SPARK-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088429#comment-15088429
 ] 

Bryan Cutler edited comment on SPARK-12701 at 1/8/16 12:07 AM:
---------------------------------------------------------------

I can submit a PR for this.
-changed issue to improvement, since this only caused a problem for my own 
testing


was (Author: bryanc):
I can submit a PR for this.

> Logging FileAppender should use join to ensure thread is finished
> -----------------------------------------------------------------
>
>                 Key: SPARK-12701
>                 URL: https://issues.apache.org/jira/browse/SPARK-12701
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>            Reporter: Bryan Cutler
>            Priority: Minor
>
> Currently, FileAppender for logging uses wait/notifyAll to signal that the 
> writing thread has finished.  While I was trying to write a regression test 
> for a fix of SPARK-9844, the writing thread was not able to fully complete 
> before the process was shutdown, despite calling 
> {{FileAppender.awaitTermination}}.  Using join ensures the thread completes 
> and would simplify things a little more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to